fix(templates/http-go): Remove scheduler flag from http-go build command #2981
+11
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
@deadprogram I blindly copied |
Contributor
Not at all! Please remove for compatibility. I am not using any Go routines in my specific use cases, so I was able to remove even more size from the module that way. |
itowlson
approved these changes
Jan 14, 2025
adamreese
force-pushed
the
fix/templates-go
branch
from
b0cf0dd to
0a6db47
Compare
itowlson
approved these changes
Jan 14, 2025
This removes the `-scheduler=none` flag from the build command in the http-go template. Including this flag prevents Spin applications using `http.Transport` from compiling. ``` ❯ spin build Building component http-roundtrip-test with `tinygo build -target=wasip1 -gc=leaking -scheduler=none -buildmode=c-shared -no-debug -o main.wasm .` /opt/homebrew/Cellar/tinygo/0.35.0/src/net/http/transfer.go:213:2: attempted to start a goroutine without a scheduler Error: Build command for component http-roundtrip-test failed with status Exited(1) ``` Signed-off-by: Adam Reese <[email protected]>
adamreese
force-pushed
the
fix/templates-go
branch
from
0a6db47 to
8f80acb
Compare
itowlson
approved these changes
Jan 14, 2025
Collaborator
itowlson
left a comment
itowlson
left a comment
There was a problem hiding this comment.
Man, thanks for finding all this stuff. Sorry for leaving it in this state for you.
Contributor
Author
|
It took some artisanal greping to find them all |
Collaborator
|
@fermyon/administrators Please force merge. I believe the JS CI failures are unrelated, the double-echo is a known flake, and the Go one is because it's using the templates from main, which this PR fixes. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the
-scheduler=noneflag from the build command in the http-go template. Including this flag prevents Spin applications usinghttp.Transportfrom compiling.